Re: [PATCH 3/3] make --max-pack-size argument to 'git pack-object' count in bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 Feb 2010, Junio C Hamano wrote:

> -- >8 --
> Subject: [PATCH] fast-import: count --max-pack-size in bytes
> 
> Similar in spirit to 07cf0f2 (make --max-pack-size argument to 'git
> pack-object' count in bytes, 2010-02-03) which made the option by the same
> name to pack-objects, this counts the pack size limit in bytes.
> 
> In order not to cause havoc with people used to the previous megabyte
> scale, and because this is a sane thing to do anyway, a minimum size of 1
> MiB is enforced to avoid an explosion of pack files.
> 
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>

ACK.

>  --max-pack-size=<n>::
> -	Maximum size of each output packfile, expressed in MiB.
> -	The default is 4096 (4 GiB) as that is the maximum allowed
> +	Maximum size of each output packfile.
> +	The default is 4 GiB as that is the maximum allowed
>  	packfile size (due to file format limitations). Some
>  	importers may wish to lower this, such as to ensure the
>  	resulting packfiles fit on CDs.

What file format limitation is alluded to here?  It has been a while 
since the 4GB limit on pack file format has been removed.  If this is a 
limitation of fast-import only then maybe this should be explained more 
explicitly.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]