Re: [PATCH v6] add --summary option to git-push and git-fetch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry D'Anna <larry@xxxxxxxxxxxxxx> writes:

> * Larry D'Anna (larry@xxxxxxxxxxxxxx) [100131 19:57]:
>> So i guess you're saying that it would be better for update_local_ref and
>> print_summary_for_push_or_fetch to clear the flags, and just pass a rev_info for
>> print_summary_for_push_or_fetch instead of quickref?
>
> So, should I submit a version of the patch that does it this way?  Should it use
> a subprocess?  Should the option be called something other than --summary?

I dunno.  If it delegated to a subprocess it would certainly be easier to
review and get convinced that the change won't affect object flags for
other parts of the system in bad ways, but there obviously is a
performance downside.

I vaguely recall there also were comments on the output format not being
consistent with output of similar nature from other parts of the system,
but I am not the one who is particularly interested in this feature, so
I'll let you and the list decide.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]