Frank Li <lznuaa@xxxxxxxxx> writes: > getpass at mingw.c is direct read character with function _getch(). > GUI application, such tortoisegit will halt when http need > password input because gui don't know git wait for inputing passwords. > > To resolve this problem, I have two options. > Options 1: > Check if terminal is exist, if exist, using old > method. Otherwise launch internal password dialog. > > Options 2: > like openSSH, Check if terminal is not exist and > environment HTTP_ASKPASS exist, if true, run application which > HTTP_ASKPASS point, otherwise using old ways. > > Which one do you prefer, I can implement it. Is "Neither, at least not yet" an accepted answer? - If you look at an environment, why check terminal at all? If the calling application wants to specify "here is the way to ask the user for a password" with it, why not use it unconditionally? - Why is it HTTP_ASKPASS? If other codepaths (e.g. "ssh passphrase", "svn password") that do not have anything to do with HTTP transfer also wants that feature, wouldn't it be easier for the users to specify one single "password dialog" helper program, that is launched by various parts of git, and ask "I need the HTTP password to access li.org", "I need to unlock the ssh key for fl@xxxxxx", etc? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html