On Mon, Feb 1, 2010 at 12:10 PM, Paolo Bonzini <bonzini@xxxxxxx> wrote: >> + OPT_BOOLEAN(0, "ff",&ff_ok, "allow fast forward"), > > Why should this not be the default? Maybe it could be the default, but in this case it should be made compatible with -n option (and perhaps other options) for backward compatibility, and this would probably need more involved changes. Thanks, Christian. > Instead, you'd add --no-ff. This would > simplify 6/6 further, like > > eval sha1=\$$# > ... > output git cherry-pick "$@" > > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html