Re: [RFH] rpm packaging failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Todd Zullinger <tmz@xxxxxxxxx> writes:

> Junio C Hamano wrote:
>> Here is an attempt to fix it, but help is very appreciated, as I don't
>> know what the accepted way is to ship Python modules is in the RPM world.
>
> Perhaps this will work well.  I only tested it on Fedora 10, but I
> believe it should work on RHEL/CentOS and most other rpm-based
> distros.  We may well want to package the python bits in a subpackage,
> much as the perl modules are.  Anyone have thoughts on that?

Thanks.

The files that are problematic are only infrastructure bits to support
"remote helpers written in Python" (which we don't ship at all yet).

Once we start shipping real remote helpers, separating Python bits out
into its own package would make a lot of sense.  People who want to use
foreign scm helpers that happen to be written in Python would need it, and
all others don't.

But I suspect that a safer alternative at least for 1.7.0 would be to
leave these files out altogether.  As I understand the current state, it
is an unused but required package dependency on Python, a downside without
an upside.  Is it Ok with "remote helpers in Python" folks (I think Sverre
and Johan are principal parties), or did I miss some reason that these
need to be installed/installable, perhaps to support third party packages
that already exist?

And if the removal is the way to go for 1.7.0, is the following an Ok
approach to do that removal (this is asking an RPM help again to Todd)?



 git.spec.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/git.spec.in b/git.spec.in
index ab224f7..ec3451a 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -112,6 +112,7 @@ rm -rf $RPM_BUILD_ROOT
 make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" DESTDIR=$RPM_BUILD_ROOT \
      %{path_settings} \
      INSTALLDIRS=vendor install %{!?_without_docs: install-doc}
+rm -fr $RPM_BUILD_ROOT%{_libdir}/python*
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';'
@@ -190,6 +191,9 @@ rm -rf $RPM_BUILD_ROOT
 # No files for you!
 
 %changelog
+* Sat Jan 30 2010 Junio C Hamano <gitster@xxxxxxxxx>
+- We don't ship Python bits until a real foreign scm interface comes.
+
 * Mon Feb 04 2009 David J. Mellor <dmellor@xxxxxxxxxxxxxxxx>
 - fixed broken git help -w after renaming the git-core package to git.
 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]