Re: [PATCH] rebase: don't invoke the pager for each commit summary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin, 2010-01-30:
> Hi,
> 
> On Sat, 30 Jan 2010, Markus Heidelberg wrote:
> 
> > diff --git a/git-rebase.sh b/git-rebase.sh
> > index b5d9178..fb4fef7 100755
> > --- a/git-rebase.sh
> > +++ b/git-rebase.sh
> > @@ -86,7 +86,7 @@ continue_merge () {
> >  		fi
> >  	fi
> >  	test -z "$GIT_QUIET" &&
> > -	git log --format=%s -1 "$cmt"
> > +	GIT_PAGER='' git log --format=%s -1 "$cmt"
> 
> Would it not be better 'git --no-pager log [...]'?

That was my initial fix, but then I found this in line 519:

        GIT_PAGER='' git diff --stat --summary "$mb" "$onto"

and decided to keep consistency.

Don't know.

Markus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]