Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



apodtele wrote:
On 10/12/06, Martin Waitz <tali@xxxxxxxxxxxxxx> wrote:
On Thu, Oct 12, 2006 at 03:37:17PM -0400, apodtele wrote:
> Instead of conditionally scaling the stat graph for large changes,
> always scale it asymptotically: small changes shall appear without any
> distortions.

very nice idea!

> +     return it * width / (it + width) + 1;

but wouldn't this formula result in at least 1, even for a 0 change?
Perhaps we'd have to special case an input of 0?
[...]
+    if (it)
+        return it * width / (it + width) + 1;
+    else
+        return 0;

No conditional needed:

	return it * width / (it + width - 1)
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]