On Thursday 28 of January 2010 22:57:16 Junio C Hamano wrote: > Michal Sojka <sojkam1@xxxxxxxxxxx> writes: > > +test_expect_success 'setup submodule' ' > > + rm -rf * .* > > Yikes. Please don't do this. > > [...] > > but it would be preferable to be even more explicit "rm -fr ?* .git". Fixed. I did it like you suggested. > Also make sure you don't break the chain of "&&" unnecessarily. > Fixed. I've also split each my test into two separate tests. In the first one I perform the rewrite and in the second I test that the result is what was expected. I did it because the other tests in this file are structured the same way. Cheers, Michal -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html