On Thu, Jan 28, 2010 at 09:52:16AM -0500, Jeff King wrote: > I'm running the whole test suite under valgrind for the current > 'master'. This was the first hit, but it's very s-l-o-w, so there might > be more as the day progresses. And here they are. The first two are actual bugs, the third silences a false positive: [1/3]: fix memcpy of overlapping area [2/3]: fix off-by-one allocation error [3/3]: add shebang line to git-mergetool--lib.sh It really has been a while since I've run the whole test suite under valgrind. The breakage in 3/3 dates back to last April. The bug in 1/3 is also quite old (v1.5.0). I'm not sure why I didn't find it in previous valgrind runs; perhaps it is only recent valgrinds that have grown support for finding overlapping memcpy. The bug in 2/3 is new, and has never been in a released version. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html