In do_git_gui() the path of the git executable has to be put into a list, otherwise calling it will fail when when spaces are present in its path. Reported-by: Heiko Voigt <hvoigt@xxxxxxxxxx> Signed-off-by: Jens Lehmann <Jens.Lehmann@xxxxxx> --- Am 28.01.2010 03:56, schrieb Shawn O. Pearce: > Jens Lehmann (2): > git-gui: Use git diff --submodule when available > git-gui: Add a special diff popup menu for submodules Today Heiko reported me this bug I introduced with the second patch. Sorry for the hassle. git-gui/git-gui.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh index a64191d..840f45c 100755 --- a/git-gui/git-gui.sh +++ b/git-gui/git-gui.sh @@ -2000,7 +2000,7 @@ proc do_git_gui {} { # -- Always start git gui through whatever we were loaded with. This # lets us bypass using shell process on Windows systems. # - set exe [_which git] + set exe [list [_which git]] if {$exe eq {}} { error_popup [mc "Couldn't find git gui in PATH"] } else { -- 1.7.0.rc0.163.g808df.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html