Re: [PATCH] diff: fix 2 whitespace issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I noticed this breakage sometime last week and it was sitting at
near the bottom of my stack of things to look at.  Ray's
bugreport and your fix were quite timely.  Thanks.

You mentioned six whitespace problems but I counted only three
and the test failed on "CR at the end"; the test vector was easy
to hand-fix thanks to the "index" line.

This patch is an example that we do not want to transmit files
that has CRs in e-mail.  These CRs appear in format-patch
output, so either the user needs to do --attach (and perhaps the
option needs to do base64 or qp in such a case) or format-patch
needs to treat a blob with CR as binary and emit binary diff?
The latter is not appropriate since patches apply just fine with
CR in them.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]