Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Thanks. Due to the size of the change, I would acknowledge it only if you
> have a proof that the reduced startup costs are noticable, for example, by
> running the test suite.
>
> What's the deal with bswap? Isn't it an unrelated change? It needs some
> better justification. It is unobvious because it is not straight-forward
> "use pointer to function that was looked up instead of function".
>
> Will the result not break the MSVC build?
>
> -- Hannes
>

"git status" calls ntohs function, which was loaded from ws2_32.dll
I've noticed that bswap.h contains implementation of ntohl htonl functions,
so I decided to add implementation of ntohs htons functions, which is
pretty trivial.
After that call to "git status" doesn't load ws2_32.dll
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]