On Thursday 28 January 2010, SZEDER Gábor wrote: > Hi Johan, > > On Thu, Jan 28, 2010 at 02:23:35AM +0100, Johan Herland wrote: > > On Thursday 28 January 2010, SZEDER Gábor wrote: > > > ... and it will offer refs unless after -m or -F, because these two > > > options require a non-ref argument. > > > > Maybe-NAK. > > > > The patch is probably good in itself, and the intent is certainly good, > > but we're currently discussing deprecating the -m/-F options to "git > > notes edit" (see > > http://article.gmane.org/gmane.comp.version-control.git/138215), and if > > that's where we go, there's no point "encouraging" their use by adding > > bash- completions for them... > > -m and -F are not encouraged, because they are not offered (short > options in general are never offered by the completion script). > However, their presence or absence is taken into account to offer > something sensible: refs after 'git notes edit <TAB>', files after > 'git notes edit -F <TAB>'. Note, that I chose 'edit' here, because > currently it's the only subcommand taking '-F', but it will actually > work the same way with the upcoming 'add' and 'append' subcommands. Ah, ok, then. I revoke my NAK. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html