Re: git-format-patch should include a checksum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Juliusz Chroboczek <jch@xxxxxxxxxxxxxx> writes:

> I'm seeing Git patches being corrupted by mailers and still apply
> correctly.  It would be great if git-format-patch could include a hash
> of the patch body (and commit message); git-am should check the hash,
> and refuse to commit if the patch was corrupted (--force should override
> that, of course).

Do you have an example of such corrupted and incorrectly applied patches?
What kind of corruption are you talking about?

format-patch/am pair is designed to be lenient, allowing people to write
additional messages after the three-dash lines after the output is made
but before it is given to the MUA for sending the result out, for example,
so adding a checksum over the entire output and forcing a check upon
application is really a bad idea, even though, provided if the patch is
done cleanly, it might be acceptable as an optional feature.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]