On Mon, Jan 25, 2010 at 01:32:44PM +0100, Johannes Sixt wrote: > This is a followup to ac0ba18 (run-command: convert simple callsites to > use_shell, 2009-12-30), for consistency. > > Signed-off-by: Johannes Sixt <j6t@xxxxxxxx> > --- > Jeff, > > is there a reason that this was not part of the original patch? No, I must have just missed it (I don't remember omitting it for a particular reason at the time, and after looking at it now, it looks sane to me). After this, git grep '"sh"' turns up only two uses: one in the run-command code use_shell code path, and the other in builtin-help.c. The one in builtin-help is hard to change, as it relies on direct exec instead of run-command. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html