Sebastian Schuberth <sschuberth@xxxxxxxxx> writes: > In contrast to GIT_SSH, SVN_SSH requires quotes for paths that contain > spaces. As GIT_SSH will not work if it contains quotes, it is safe to > assume it never contains quotes. Also, adding quotes to SVN_SSH for paths > that do not contain spaces does no harm. So we always add quotes when > deriving SVN_SSH from GIT_SSH. > > This fixes msysGit issue 385, see > http://code.google.com/p/msysgit/issues/detail?id=385 > > Signed-off-by: Sebastian Schuberth <sschuberth@xxxxxxxxx> As the patch clearly is inside "msys-only" codepath, I don't mind bypassing Eric and apply this directly to my tree before I tag 1.7.0-rc0, but may I ask why this quoting magic matters only on msys? > --- > git-svn.perl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/git-svn.perl b/git-svn.perl > index 650c9e5..ef39a9f 100755 > --- a/git-svn.perl > +++ b/git-svn.perl > @@ -26,6 +26,7 @@ if (! exists $ENV{SVN_SSH}) { > $ENV{SVN_SSH} = $ENV{GIT_SSH}; > if ($^O eq 'msys') { > $ENV{SVN_SSH} =~ s/\\/\\\\/g; > + $ENV{SVN_SSH} =~ s/(.*)/"$1"/; > } > } > } > -- > 1.6.6.265.ga0f40 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html