On Thu, 21 Jan 2010, Pal-Kristian Engstad wrote:
> Improve git-p4 submit performance on newer (from 2009.2) Perforce
> servers by changing "p4 diff -du" to "p4 diff -dub". This change is
> harmless since the output is only used for display purposes.
>
> Signed-off-by: Pal-Kristian Engstad <pal_engstad@xxxxxxxxxxxxxx>
Why is the b flag impacting performance?
And even if for display purposes, why might you wish not to see
differences in whitespace changes?
> ---
> contrib/fast-import/git-p4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index ab538b3..ec26cac 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -715,7 +715,7 @@ class P4Submit(Command):
> submitTemplate = self.prepareLogMessage(template, logMessage)
> if os.environ.has_key("P4DIFF"):
> del(os.environ["P4DIFF"])
> - diff = p4_read_pipe("diff -du ...")
> + diff = p4_read_pipe("diff -dub ...")
>
> newdiff = ""
> for newFile in filesToAdd:
> --
> 1.6.5.2.6.gc3c1e.dirty
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html