Re: [PATCH] http/remote-curl: coddle picky servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 21, 2010 at 08:24:02AM -0800, Shawn O. Pearce wrote:
> Tay Ray Chuan <rctay89@xxxxxxxxx> wrote:
> > On Fri, Jan 22, 2010 at 12:07 AM, Mike Hommey <mh@xxxxxxxxxxxx> wrote:
> > > Look closely at the start of the requested URL: /gitweb.cgi...
> > > It comes from this rule:
> > >
> > > RewriteCond %{QUERY_STRING} ^(.+)$
> > > RewriteRule ^/(.*)$ /gitweb.cgi$1 [L,PT]
> > >
> > > which is global to the virtual host.
> > >
> > > Anyways, while git.debian.org can certainly be fixed for that, other
> > > servers may want to do some different things with urls with parameters.
> > 
> > heh, I was suspecting some URL rewriting was going on.
> > 
> > Is this an issue that should be fixed in gitweb?
> 
> I don't see why it should be.  gitweb isn't a service CGI.  I find
> it odd that someone would configure their website to route anything
> with a query string into gitweb.  WTF?

There was a good reason for it, but the implementation was too broad:
The main gitweb list (http://git.debian.org/) is made statically,
because it is too long for gitweb to create it in a timely fashion.

So while the main page is made to be a static file, when the request has
a query string, which means it's not the main gitweb list, the cgi is
used.

Except this rule was also used for unrelated urls.

But as I said in my reply to Tay Ray Chuan, it's fixed.

Mike
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]