Re: [PATCH] Makefile: honor NO_CURL when setting REMOTE_CURL_* variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 19, 2010 at 04:39:12PM +0100, Johannes Sixt wrote:
> Previously, these variables were set before there was a chance to set
> NO_CURL.
> 
> This made a difference only during 'make install', because by installing
> $(REMOTE_CURL_ALIASES), the rule  tries to access $(REMOTE_CURL_PRIMARY),
> which was never installed. On Windows, this fails; on Unix, stale symbolic
> links are created.
 
<snip patch>

I didn't even compile-test it, but based on quick look I don't see any
obivous mistakes. There are no references to REMOTE_CURL_* in section
moved over, and the variable values should not differ unless section skipped
sets NO_CURL. So:

Acked-by: Ilari Liusvaara <ilari.liusvaara@xxxxxxxxxxx>

-Ilari
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]