On Sun, Jan 17, 2010 at 02:03:48PM -0800, Junio C Hamano wrote: > We could say something like > > if (!(user_ident_explicitly_given & IDENT_EMAIL_GIVEN)) > > and it probably is a safer change on platforms with GECOS available, but > then wouldn't msysgit folks have to fork this code? I hadn't thought to be specific to "email must be given". That is, I had assumed if you gave a name but not email, you would also be considered competent enough to avoid the warning. But I really can't see anybody doing that, so the semantics you suggest above are fine by me. As far as Windows goes, I have no opinion on the correct behavior. But if they are going to do something different, your encapsulation makes sense to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html