On Sat, Jan 16, 2010 at 06:46:33PM -0800, Junio C Hamano wrote: > * jc/ident (2010-01-08) 3 commits > - ident.c: treat $EMAIL as giving user.email identity explicitly > (merged to 'next' on 2010-01-10 at f1f9ded) > + ident.c: check explicit identity for name and email separately > + ident.c: remove unused variables > > Opinions on the topmost one? I don't see a problem with the top one as long as the order is (in order of decreasing precedence): 1. GIT_*_EMAIL 2. git config 3. EMAIL 4. `whoami`@`hostname` which from my tests seems to be the case. That is, even though environment variables generally take precedence over config, git-specific environment variables and config take precedence over generic config. Otherwise I think we may surprise some people who have EMAIL set. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html