On Fri, Jan 15, 2010 at 11:30 PM, Johannes Sixt <j6t@xxxxxxxx> wrote: > On Freitag, 15. Januar 2010, Erik Faye-Lund wrote: >> @@ -729,7 +729,7 @@ static pid_t mingw_spawnve(const char *cmd, const char >> **argv, char **env, return -1; >> } >> CloseHandle(pi.hThread); >> - return (pid_t)pi.hProcess; >> + return (pid_t)pi.dwProcessId; >> } > > You are not using the pi.hProcess anymore, so you must close it. > No. If I do, the pid becomes invalid after the process is finished, and waitpid won't work. I couldn't find anywhere were we actually were closing the handle, even after it was finished. So I don't think we leak any more than we already did (for non-daemon purposes). -- Erik "kusma" Faye-Lund -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html