On Tue, 10 Oct 2006, Daniel Barkalow wrote:
>
> Would the three of you agree to license date.c under the LGPL or BSD? It
> looks like you're the only authors of non-trivial changes [1]. And it seems
> reasonable to want the date parsing thing under non-GPL terms outside of
> git.
I'm not a huge fan of the LGPL, especially with the recent issues of
GPLv3. The reason? The LGPL is expressly designed to be compatible with
the GPL, but it's designed to be compatible with any version (and you
can't limit it, the way you can the real GPL).
So you can take LGPL 2.1 code, and relicense it under GPLv3, and make
changes to it, and those changes won't be available to a GPLv2 project.
That said, I don't think the date.c code is all that important, and I
don't see why anybody would do something nasty like that anyway, so I
guess I don't actually care. A lot of the approxidate code was actually
written as a joke, and it will parse just about anything without any
error, and without telling you that it returned a date that may not make
any sense at all.
For example, currently
./test-date "$(cat date.c)"
returns
Tue Nov 30 11:58:59 1937
for me, but don't ask me why. It's just put together the random numbers
and month-names embedded in the source and made some insane decision that
it must be a date (since you told it so). And it never returned an error.
Some other things are just silly and not even correct
./test-date "One year ago yesterday at tea-time"
which doesn't even give the right answer (because it will go _backwards_
to tea-time on Oct 8th, even though it obviously _should_ return "Oct 9,
17:00". I don't have the energy to try to fix it.
It also needs this important patch to be complete. I don't know how this
could ever have fallen through the cracks!
Linus
---
diff --git a/date.c b/date.c
index 1825922..0b06994 100644
--- a/date.c
+++ b/date.c
@@ -657,6 +657,7 @@ static const struct typelen {
{ "hours", 60*60 },
{ "days", 24*60*60 },
{ "weeks", 7*24*60*60 },
+ { "fortnights", 2*7*24*60*60 },
{ NULL }
};
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html