On Tue, Jan 12, 2010 at 10:57:03PM -0800, Junio C Hamano wrote:
> > + if (!user_ident_explicitly_given) {
> > + strbuf_addstr(&format, "\n Committer: ");
> > + strbuf_percentquote_buf(&format, &committer_ident);
> > + }
>
> This is much better.
>
> We might want an advice message inside the latter case, helping the user
> learn how to spell his name correctly. This is designed to trigger for
> people/repositories that are not configured, and by definition the
> majority of that target audience are new people.
>
> The extra message will disappear once committer information is explicitly
> given, there is no need to protect the advice message with the usual
> "advice.*" configuration.
Just adding the "Committer:" reminder is slightly annoying (though
perhaps some people will even like it). Adding a big advice message on
every commit is going to be annoying to everyone who sees it, and is
really crossing the line of "we don't really support implicit identities
anymore", since anyone seeing it is going to want to fix it.
I know there has been some discussion of that area in the last few
months, but I admit I didn't pay any attention. Is that the direction we
want to move in? I don't have a particular problem with it, but I want
to point out that if there _are_ people who really like the implicit
ident feature, we are effectively killing it off for them.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html