On Wed, Jan 13, 2010 at 1:48 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > We still allow people to pass --[no-]ext-grep on the command line, > but the option is ignored. Perhaps this squashed in on top? (If gmail's web-interface mangles this I can resend.) diff --git a/Documentation/config.txt b/Documentation/config.txt index a1e36d7..6a96d9d 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -645,14 +645,6 @@ color.grep:: `never`), never. When set to `true` or `auto`, use color only when the output is written to the terminal. Defaults to `false`. -color.grep.external:: - The string value of this variable is passed to an external 'grep' - command as a command line option if match highlighting is turned - on. If set to an empty string, no option is passed at all, - turning off coloring for external 'grep' calls; this is the default. - For GNU grep, set it to `--color=always` to highlight matches even - when a pager is used. - color.grep.match:: Use customized color for matches. The value of this variable may be specified as in color.branch.<slot>. It is passed using diff --git a/builtin-grep.c b/builtin-grep.c index 4adb971..3d6ebb5 100644 --- a/builtin-grep.c +++ b/builtin-grep.c @@ -34,8 +34,6 @@ static int grep_config(const char *var, const char *value, void *cb) opt->color = git_config_colorbool(var, value, -1); return 0; } - if (!strcmp(var, "color.grep.external")) - return git_config_string(&(opt->color_external), var, value); if (!strcmp(var, "color.grep.match")) { if (!value) return config_error_nonbool(var); diff --git a/grep.h b/grep.h index 75370f6..0c61b00 100644 --- a/grep.h +++ b/grep.h @@ -85,7 +85,6 @@ struct grep_opt { int max_depth; int funcname; char color_match[COLOR_MAXLEN]; - const char *color_external; int regflags; unsigned pre_context; unsigned post_context; -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html