On Sun, Jan 10, 2010 at 7:14 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Jonathan Nieder wrote:
>> Kevin Leung wrote:
>> > read_pipe() returns "\n". We need to remove it before passing it
>> > to system().
>> >
>> > Signed-off-by: Kevin Leung <kevinlsk@xxxxxxxxx>
>>
>> If I understand correctly, this is a cosmetic change:
>
> ... and of course I didn't the subject. Sorry about that. Thanks
> for cleaning up my mess.
>
> Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
>
>> What is the rationale for the rewritten system() line? I would have
>> understood a change to
>>
>> os.spawnlp("sh", "-c", editor + " \"$@\"", fileName)
>
> I am still curious about this, though it is not so important.
You are right, the system() line is not so important. I can revert
that line of change.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html