2010/1/7 Junio C Hamano <gitster@xxxxxxxxx>: > I am a bit unhappy about the duplication. The text of this function is > different from the one in "rebase" proper, but they implement essentially > the same logic. I was tempted to suggest having a common helper function, > but as Dscho mentioned "rebase -i" implementation does not share much with > "rebase" (even though it shares the external command line interface from > the end user's point of view), and I don't see a readily available place > (other than in git-sh-setup) to do so. Is there a reason that non-interactive rebase can't just be implemented as "git rebase -i" but without actually launching an editor to edit the commit list? This would resolve any other inconsistencies between the two as well, notably that non-interactive rebase sometimes refuses to do the rebase I requested because "Current branch master is up to date," while interactive rebase is willing to do it. (Personally I prefer the latter behaviour, since I don't like tools that think they're smarter than me :)) Avery -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html