On Fri, Jan 8, 2010 at 2:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Erik Faye-Lund <kusmabite@xxxxxxxxxxxxxx> writes: > >>> On Fri, 8 Jan 2010, Johannes Sixt wrote: >>> >>>> Erik Faye-Lund schrieb: >>>> > Python is not commonly installed on Windows machines, so >>>> > we should disable it there by default. >>>> > >>>> > --- a/Makefile >>>> > +++ b/Makefile >>>> > @@ -1027,6 +1027,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) >>>> > + NO_PYTHON = YesPlease >>>> >>>> I'm worried that with this solution it is impossible to re-enable Python >>>> in config.mak (how do you undefine a Makefile variable?); >> >>> How about >>> >>> NO_PYTHON= >>> >>> in config.mak? >> >> That doesn't work for me, at least not out of the box. NO_PYTHON is >> still defined, it's just defined to an empty string. > > I think Dscho is right. "ifdef FOO" yields (and should yield) false if > FOO is set to empty. > In that case I guess I messed up my test. I'll retest. Yes, I messed up. "NO_PYTHON=" works like a charm. So, no repost :) -- Erik "kusma" Faye-Lund -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html