Eric Wong wrote: > Andrew Myrick <amyrick@xxxxxxxxx> wrote: > >> diff --git a/git-svn.perl b/git-svn.perl >> index 650c9e5..8c7c034 100755 >> --- a/git-svn.perl >> +++ b/git-svn.perl >> @@ -3052,12 +3052,36 @@ sub check_cherry_pick { >> for my $range ( @ranges ) { >> delete @commits{_rev_list($range)}; >> } >> + for my $commit (keys %commits) { >> > > Hi Andrew, > > I'll again defer to Sam for Acks on these. Test cases would be nice to > have, too. > They look fine to me, agreed a test case would be nice and make sure the features aren't lost later inadvertently. Thanks Andrew, Sam -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html