On Wed, 6 Jan 2010, Jonathan Nieder wrote: > The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid > trouble when ALL_CFLAGS changes. > > The pattern only applies to one file (ppc/sha1ppc.S) and that > file does not use any #ifdefs, so leaving the dependency out is > probably harmless. Nevertheless, it is safer to include the > dependency in case future code's behavior does depend on the > build flags. Is the PPC SHA1 code still needed? Is it actually ever used? We have block-sha1/* which is already about just as fast if not faster on most targets. So I'd simply remove the ppc directory and its content which is the only remaining platform specific assembly code in the source tree. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html