Junio C Hamano schrieb:
Regarding your "[PATCH 8/6] t4030, t4031", I have two questions:
Recall that MSYS bash converts POSIX style absolute paths to Windows style
absolute paths. Unfortunately, it converts a program argument that begins
with a double-quote and otherwise looks like an absolute POSIX path, but
in doing so, it strips everything past the second double-quote[*]. This
case is triggered in the two test scripts. The work-around is to place the
Windows style path between the quotes to avoid the path conversion.
(1) Does "Windows style path" here mean what $(pwd) returns as opposed to
what is in $PWD?
Yes. $PWD is of the form /c/foo/bar; pwd is a function in test-lib.sh that
ensures it returns the form c:/foo/bar.
(2) The patch reads like this:
- git config diff.foo.textconv "\"$PWD\""/hexdump &&
+ git config diff.foo.textconv "\"$(pwd)\""/hexdump &&
Does "strips everything past the second dq" mean "drops '/hexdump'"?
Yes.
If so, would this also work (I am not suggesting to change it, just
asking for information)?
- git config diff.foo.textconv "\"$PWD\""/hexdump &&
+ git config diff.foo.textconv "\"$PWD/hexdump\"" &&
It would work, too, but it would depend on very bogus behavior of the MSYS
bash.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html