Jens Lehmann <Jens.Lehmann@xxxxxx> writes: > Am 05.01.2010 19:31, schrieb Junio C Hamano: >> Jens Lehmann <Jens.Lehmann@xxxxxx> writes: >>> b) new unignored files >>> IMO these files should show up too (the superproject doesn't show >>> ignored files, the submodule state shouldn't do that either). But >>> OTOH i don't see a possibility for loss of data when this state is >>> not shown. >> >> I don't know if we are talking about the same scenario. What I had in >> mind was: >> >> cd sub >> edit new-file >> tests ok and be happy >> git commit >> cd .. >> git status >> git commit >> >> forgetting that only you have sub/new-file in the world. It is not loss >> of data, but still bad. Forgetting to add a new-file and committing in a >> project without submodule doesn't lose data, but the resulting commit will >> be seen as broken by other people. > > I'm not quite sure, i was rather thinking about something like this: > > cd sub > edit new-file > cd .. > <use sub/new-file here, test ok and be happy> > git status > git commit > git push > > git status won't show you that sub has any new files and so you won't be > reminded that you still have to add, commit and push it in the submodule > before you should even commit, let alone push in the superproject. > > It is a possible breakage for other people if sub/new-file stays unnoticed. > That's IMO a good point for showing these files too. Yeah, your "i don't see a possibility for lost of data when this state is not shown" confused me into thinking as if you were saying it is not _too_ bad if we didn't show the information. After all we _were_ in agreement. We both think the user should be told about untracked files in submodule directory when inspecting the status to make a commit in the superproject. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html