On Mon, Jan 04, 2010 at 04:50:39PM +0100, Johannes Sixt wrote: > >>On Windows, we need the shbang line to correctly invoke shell scripts via > >>a POSIX shell, except when the script is invoked via 'sh -c' because > >>sh (a bash) does "the right thing". Since nowadays the clean and smudge > >>filters are not always invoked via 'sh -c' anymore, we have to mark the > >>the one in t0021-conversion with #!$SHELL_PATH. > > > >Hrm. This does mean we might be breaking users who have helper scripts > >in a similar state to those in the test suite... > > Not helper scripts in general, but only clean and smudge filters, > because these have been invoked with "sh -c" so far. Everything else, > that was not run via "sh -c", but now is, is safe. I converted more than that; see my 2/6. It is also the pager, the imap-send tunnel helper, and external merge helpers. Not the editor, since it already had the no-metacharacters optimization (though it, too, could be affected if we implement your DWIM trick instead of the metacharacter thing). So I think we need to make a conscious decision that this is an acceptable change of behavior (and I am totally fine with the change happening -- I just want to be clear about the extent of what is being changed). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html