Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes: > Quoting Thiago Farina <tfransosi@xxxxxxxxx> > >> Signed-off-by: Thiago Farina <tfransosi@xxxxxxxxx> >> --- >> Removed the LF from the end of the strings. > > Trying this patch makes t6030-bisect-porcelain.sh fail for me. Was this tested at all? I noticed it as well; will squash this in. diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh index def397c..c51865f 100755 --- a/t/t6030-bisect-porcelain.sh +++ b/t/t6030-bisect-porcelain.sh @@ -423,7 +423,7 @@ test_expect_success 'skipped merge base when good and bad are siblings' ' grep "merge base must be tested" my_bisect_log.txt && grep $HASH4 my_bisect_log.txt && git bisect skip > my_bisect_log.txt 2>&1 && - grep "Warning" my_bisect_log.txt && + grep "warning" my_bisect_log.txt && grep $SIDE_HASH6 my_bisect_log.txt && git bisect reset ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html