Re: [PATCH v3 3/3] Smart-http tests: Test http-backend without curl or a webserver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 2, 2010 at 1:03 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> Tarmigan Casebolt <tarmigan+git@xxxxxxxxx> wrote:
>>  GET() {
>> -     return 0
>> +     REQUEST_METHOD="GET" \
>> +     run_backend "/repo.git/$1" &&
>> +     grep "Status" act.out >act
>> +     if [ $? -eq 1 ];
>
> I think this should be spelled as:
>
>        if ! grep "Status" act.out >act; then
>                printf "Status: 200 OK\r\n" > act
>        fi

OK.  I had figured the "1" would mean "no matches not found"  rather
than some other error like "file does not exist".  Not sure how
portable that error value convention is for greps though, so I've
changed it as you suggested.

Thanks,
Tarmigan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]