Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes: > Junio, could you tell us what happened to this thread? > > I use this patch myself, and it works really well. I stopped promoting the patch after Peff mentioned he was planning a rework of textconv, but now I re-read it, I think his rework would be orthogonal to the patch. Also Peff gives a good hint about borrowing how launch_editor() calls out to the shell. I think the codepath we fork&exec user-defined commands (not hooks, but filters like smudge/clean/textconv and EDITOR/PAGER that take a command line) need to be first enumerated, then we need to see if we can refactor what launch_editor() does into a common helper function. I felt it was unclear what we would want to do with GIT_EXTERNAL_DIFF, diff.external, and diff.<driver>.command trio, but I tend to agree that we should run things the same way, honoring $IFS and shell everywhere. http://thread.gmane.org/gmane.comp.version-control.git/135250/focus=135312 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html