This reuses many of the tests from t5560 but runs those tests without curl or a webserver. This will hopefully increase the testing coverage for http-backend because it does not require users to set GIT_TEST_HTTPD. Signed-off-by: Tarmigan Casebolt <tarmigan+git@xxxxxxxxx> --- t/t5561-http-backend-noserver.sh | 45 ++++++++++++++++++++++---------------- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git a/t/t5561-http-backend-noserver.sh b/t/t5561-http-backend-noserver.sh index 501b328..6371e97 100755 --- a/t/t5561-http-backend-noserver.sh +++ b/t/t5561-http-backend-noserver.sh @@ -5,12 +5,35 @@ test_description='test git-http-backend-noserver' HTTPD_DOCUMENT_ROOT_PATH="$TRASH_DIRECTORY" +run_backend() { + echo "$3"| \ + QUERY_STRING="${2#*\?}" \ + GIT_PROJECT_ROOT="$HTTPD_DOCUMENT_ROOT_PATH" \ + PATH_INFO="${2%%\?*}" \ + git http-backend >act.out 2>act.err +} + GET() { - return 0 + REQUEST_METHOD="GET" \ + run_backend 0 "/repo.git/$1" && + grep "Status" act.out >act + if [ $? -ne 1 ]; + then + printf "Status: $2\r\n" > exp && + test_cmp exp act + fi } POST() { - return 0 + REQUEST_METHOD="POST" \ + CONTENT_TYPE="application/x-$1-request" \ + run_backend 0 "/repo.git/$1" "$2" && + grep "Status" act.out >act + if [ $? -ne 1 ]; + then + printf "Status: $3\r\n" > exp && + test_cmp exp act + fi } logdiv() { @@ -19,26 +42,10 @@ logdiv() { . "$TEST_DIRECTORY"/t556x_common -run_backend() { - REQUEST_METHOD=GET \ - GIT_PROJECT_ROOT="$HTTPD_DOCUMENT_ROOT_PATH" \ - PATH_INFO="$2" \ - git http-backend >act.out 2>act.err -} - -path_info() { - if test $1 = 0; then - run_backend "$2" - else - test_must_fail run_backend "$2" && - echo "fatal: '$2': aliased" >exp.err && - test_cmp exp.err act.err - fi -} - test_expect_success 'http-backend blocks bad PATH_INFO' ' config http.getanyfile true && + REQUEST_METHOD="GET" && run_backend 0 /repo.git/HEAD && run_backend 1 /repo.git/../HEAD && -- 1.6.6.62.g67314 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html