Re: [PATCH 2/2] Smart-http: check if repository is OK to export before serving it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 27, 2009 at 4:10 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
> Tarmigan Casebolt <tarmigan+git@xxxxxxxxx> wrote:
>> Similar to how git-daemon checks whether a repository is OK to be
>> exported, smart-http should also check.  This check can be satisfied
>> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
>> may be set to export all repositories, or the individual repository
>> may have the file git-daemon-export-ok.
>>
>> Signed-off-by: Tarmigan Casebolt <tarmigan+git@xxxxxxxxx>
>
> Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
>
> I really think this and 1/2 should be squashed together, in which
> case you can apply my ACK to the entire thing.

Great, thanks for the ACK.

Squashing sounds good to me, I just split it so someone could verify
that the tests fail first if they want.

I've been thinking that the not_found() to a forbidden() instead.
Thoughts?  I'll send out a unified patch with that change in a reply.

Thanks,
Tarmigan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]