Junio C Hamano <gitster@xxxxxxxxx> writes: > I noticed that my build on FreeBSD-7.2-RELEASE-i386 fails without > OLD_ICONV=YesPlease. > > Is it just me and my installation (i.e. I might have failed to install > saner iconv from the port that everybody uses), or is everybody who runs > on FreeBSD using this option himself because our Makefile doesn't do that > automatically for them? > > Just in case it is the latter, here is a proposed patch. By the way, FreeBSD-8.0-RELEASE-i386 has the same issue. I'll queue it to 'maint' unless anybody objects... > Makefile | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index bde27ed..9a25c08 100644 > --- a/Makefile > +++ b/Makefile > @@ -777,6 +777,7 @@ ifeq ($(uname_O),Cygwin) > endif > ifeq ($(uname_S),FreeBSD) > NEEDS_LIBICONV = YesPlease > + OLD_ICONV = YesPlease > NO_MEMMEM = YesPlease > BASIC_CFLAGS += -I/usr/local/include > BASIC_LDFLAGS += -L/usr/local/lib -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html