Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



--- Junio C Hamano <junkio@xxxxxxx> wrote:
> Luben Tuikov <ltuikov@xxxxxxxxx> writes:
> 
> > --- Petr Baudis <pasky@xxxxxxx> wrote:
> >> Signed-off-by: Petr Baudis <pasky@xxxxxxx>
> >> ---
> >
> > First, this is a Unixism, and would confuse other OS users.
> > Second, "/" is after all _not part of the name_ of the tree/directory,
> > but part of the filesystem's path separator, let's not export it
> > to users of other OS's.
> > Third, directories/trees are already clearly 
> >   1) underlined, and
> >   2) differently colored,
> > which makes it overly obvious what it what.
> 
> I was actually hoping that we can get rid of the differences you
> cited above.
> 
> Underlines make entries harder to read, and colouring is 
> distracting; some people do not see all colours and to them it
> may not distracting but then they need another way to notice the
> differences between tree/blob.

I know, I've seen your email on that and have your patch with the
icons applied at work.  But it is black and white and I'd rather
see some nice color and shading if we're going to change that.

I don't mind using nice warm color icons in the left-most column.

   Luben

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]