2009/12/20 Junio C Hamano <gitster@xxxxxxxxx>:
> Isn't this too elaborate? git_editor() has already run and when it
> attempted to launch the editor it assigned to GIT_EDITOR in order to use
> it as an eval string.
I wanted to hide the details about the inner working of git_editor(),
but since it is only called in one place, yes, it is too elaborate.
>
> git_editor "$TODO" ||
> die_abort "Failed to run '${GIT_EDITOR:-your editor}'"
>
> would suffice, no?
Yes. Much better. I will rewrite my patch when I'll get home from
work later today.
--
Björn Gustavsson, Erlang/OTP, Ericsson AB
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html