Re: [msysGit] [PATCH] git-gui: use themed tk widgets with Tk 8.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 20 Dec 2009, Pat Thoyts wrote:

>  This patch enables the use of themed Tk widgets with Tk 8.5 and above.
>  These make a significant difference on Windows in making the application
>  appear native. The gui.usettk git config variable may be set to disable
>  this if the user prefers the classic Tk look.
>
>  On Windows and MacOSX ttk defaults to the native look as much as possible.
>  On X11 the user may select a theme using the TkTheme XRDB resource class.

Maybe you could describe a quick way to set that resource?

>  Some support is included for Tk 8.6 features (themed spinbox and native
>  font chooser for MacOSX and Windows).
> 
> Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx>
> 
> There is a screenshot of this running on Windows 7 at
> http://www.patthoyts.tk/screenshots/git-gui-win32.png
> It has been tested on Linux but not on MacOSX yet.

Please put this paragraph after the "---". Oh, and could you also include 
a screenshot without ttk?

As to the patch: it is huge.  I suspect that it would be easier to read 
and verify if it was done in two patches: the first one introducing helper 
procs that replace the existing repeated code, and a second patch that 
modifies only the helper procs to handle ttk if desired.  You did that 
with pad_label, but that proc is not defined in a central place, but 
limited to about.tcl.

Hmm?

Thanks,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]