Re: [PATCH 2/2] read-tree: at least one tree-ish argument is required

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 18 Dec 2009, Junio C Hamano wrote:

> Junio C Hamano <gitster@xxxxxxxxx> writes:
> 
> > As read-tree is a very basic and low-level Porcelain, if somebody were 
> > using it to empty the index in an existing script, this change would 
> > appear as a regression and hopefully will be caught eventually, and 
> > updating such a script can be made reasonably easy if we want to be 
> > helpful (the error message can suggest running "rm $GIT_DIR/index", 
> > for example).
> 
> IOW, I would prefer to queue something like this in the upcoming 
> version, and then later make it die().  I do not think anybody relies on 
> it, but we have been wrong before.  If the warning doesn't trigger for 
> anybody, that is also fine as well.

I fully expect it not to trigger for anybody (except maybe you, if you 
have hidden a script somewhere that uses read-tree to empty the index), 
because at least for this developer, the standard way of emptying the 
index is simply "rm .git/index".

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]