Re: [PATCHv2] am: fix patch format detection for Thunderbird "Save As" emails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/18/2009 09:38 PM, Eric Blake wrote:
Closer, but not there yet.  "$/" is still not defined.  Then, as a matter
of style, '\' is more readable than "\\" for representing a backslash.  So
as long as we are shifting to '', we might as well do it everywhere in
that line - write it like this:

} | sed -e 's/$/;/' | tr ';' '\015'>  patch1-crlf.eml

and you should be set.

Ah, I think you missed that this stuff is inside single quotes already. I would love to just do what you suggest here.

I'm a little confused because I see this in a test (am --committer-date-is-author-date) a ways down in the same file

    git cat-file commit HEAD | sed -e "/^$/q">head1&&


and following your reasoning that wouldn't be portable?

Either way, I'll look for a better replacement character instead of semi-colon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]