Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:
> Sorry to drag you into this discussion, but I felt this change is
> maint-worthy (because the behavior is not only risky, but dangerous).
>
> -- Hannes
In short, that is where we differ, as I don't think it is dangerous at
all in the "maint-worthy" sense.
"read-tree" without -m is to "populate the index from emptiness with given
trees". Unless you are hit by the bug in the auto-correction (whose fix
was maint-worthy), nobody would say read-tree without parameter and expect
that it wouldn't touch the index.
Sure, it will empty the index, so it is dangerous in the same sense that
"reset --hard" is dangerous because it will wipe all your local changes,
or "rm -rf it" will remove everything underneath it. But these are all
features that are "dangerous if you didn't mean to do so but wanted to do
something else."
Removal of such features might turn out to be maint-worthy but
Previously, it was possible to run read-tree without any arguments,
whereupon it purged the index!
doesn't justify it well enough.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html