On Thu, Dec 17, 2009 at 8:17 AM, Nanako Shiraishi <nanako3@xxxxxxxxxxx> wrote: > Quoting Jay Soffian <jaysoffian@xxxxxxxxx> > >>> But is apparently ignored by "git log -p" and "git show" which just >>> use internal diff. Is this behavior intentional? >> >> Ah, --ext-diff, and the reasoning behind requiring it for log/show is >> explained in 72909be. > > The need to give --ext-diff is mentioned in 72909be (Add diff-option > --ext-diff, 2007-06-30) but its log message doesn't 'explain' why external > diff isn't used by default and you need to pass that extra option. "To prevent funky games with external diff engines, git-log and friends prevent external diff engines from being called." Seemed reason enough to me. > Probably --ext-diff should be the default? Or available via a config option anyway. j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html