On Tue, Dec 15, 2009 at 23:13, Tarmigan <tarmigan+git@xxxxxxxxx> wrote: > On Tue, Dec 15, 2009 at 1:42 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Tarmigan <tarmigan+git@xxxxxxxxx> writes: >>> diff --git a/git-compat-util.h b/git-compat-util.h >>> index 5c59687..857e938 100644 >>> --- a/git-compat-util.h >>> +++ b/git-compat-util.h >>> @@ -79,6 +84,7 @@ >>> #include <stdlib.h> >>> #include <stdarg.h> >>> #include <string.h> >>> +#include <strings.h> >>> #include <errno.h> >>> #include <limits.h> >>> #include <sys/param.h> >> >> Other hunks are QNX specific enough but this hunk is worrisome; you cannot >> tell how you are hurting other platforms with this change. Can you tell >> declarations of which functions are missing on QNX without this change? > > strcasecmp() > http://www.opengroup.org/onlinepubs/000095399/functions/strcasecmp.html Just for completeness: http://www.qnx.com/developers/docs/6.4.1/neutrino/lib_ref/s/strcasecmp.html http://www.qnx.com/developers/docs/6.4.1/neutrino/lib_ref/s/strcmpi.html > I agree that this change could affect other platforms and they've > gotten along fine without it so far. I'm surprised no others have > needed it. Would it be better wrapped in a #ifdef? If you put the ifdef in git-compat-util.h -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html