Dear diary, on Sat, Oct 07, 2006 at 12:16:03AM CEST, I got a letter where Luben Tuikov <ltuikov@xxxxxxxxx> said that... > --- Jakub Narebski <jnareb@xxxxxxxxx> wrote: > > Gaah, the whole cae1862a3b55b487731e9857f2213ac59d5646d commit > > "gitweb: More per-view navigation bar links" is somewhat broken. > > Up to this point we used top navigation bar for commit (hash base) > > or whole project related links, while bottom part of navigation > > bar for "formats" i.e. links related to current view (passing hash) > > or for pagination. > > > > So while "snapshot" link has it's place in top navigation bar > > (but by modyfying git_print_page_nav subroutine, not by adding it > > by hand), "history" for example IMHO doesn't; history link should be > > present in the bottom part of navigation bar. Perhaps we could > > reuse git_print_page_nav for formats, for example blob wiew would have > > blob | _blame_ | _history_ | _raw_ | _HEAD_ > > while tree view would have > > tree | _snapshot_ | _history_ | _HEAD_ > > (where _text_ indices link). Perhaps _snapshot_ in tree view > > shouldn't be repeated, although top one might mean snapshot of commitish, > > bottom one snapshot of tree. > > Only a single one: of committish please. Then it will be impossible to get snapshot of any subtree (apart of manually constructing the URL). Hmm, and it's a bug that we don't show the snapshot link when listing tree entry in tree listing, I thought we did in the past...? I think we should make it more clear what each of the bars concerns, perhaps doing some more significant redesign: [summary] is redundant, you have this big project name link in the top left corner. All the other navbar options concern commit, so why not merge it with the awkward commit box below the navbars? All the "views bar" options concern the currently selected object, so why not merge it with the object "descriptor", that is the path? Patches will follow up. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html