Johan Herland <johan@xxxxxxxxxxx> wrote:
> On Monday 07 December 2009, Shawn O. Pearce wrote:
> > > + if (fanout >= 20)
> > > + die("Too large fanout (%u)", fanout);
> >
> > Shouldn't convert_num_notes_to_fanout have a guard to prevent this
> > case from happening?
>
> Well, it sort of already does (unless uintmax_t is more than 19 * 8 = 152
> bits wide... ;)
Oh, good point. :-)
> Not sure what you're getting at:
>
> - Should I add a "&& fanout < 19" condition to the while loop in
> convert_num_notes_to_fanout()?
That's what I was thinking. But given the 19 * 8 = 152 case above,
this is pointless.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html