On Sat, Dec 05, 2009 at 11:06:02AM -0800, Junio C Hamano wrote: > > Junio, I think the following should go to maint (I didn't bother > > splitting the --merge and --hard code; --merge is in v1.6.2. I assumed > > we don't care about maint releases that far back). > > Although I'll apply your patch to 'maint' and will merge it for 1.6.6, I > am not quite sure if this is the best fix in the longer run. Shouldn't we > go back to the top of the work tree and running what was asked there? I actually considered that, too, when writing the patch. But that would be inconsistent with all of the other commands that use SETUP_WORK_TREE. For example: $ git init && cd .git && git clean fatal: This operation must be run in a work tree So I think we are better to be consistent with the other commands. If somebody wants to make a separate patch to discover the work tree while in the $GIT_DIR and chdir to it, that should then be applied to all commands. I'm not opposed to it, but I also don't see it as a particularly pressing need. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html